Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): multiple bug fixes related to execution form #2573

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

batzionb
Copy link
Contributor

@batzionb batzionb commented Nov 27, 2024

  1. businessKey fixed to be only a parent assessment workflow, to avoid having workflow runs shown as assessed by themselves, and then rerun shows the inputs as readonly.
  2. fixed rerendering of form on every change, which was caused by passing formData to decorator. This constant rerendering causes the form to be unusable. instead only the initial data should be passed to the decorator.

@batzionb batzionb requested review from a team as code owners November 27, 2024 19:45
Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: a3f4078

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@janus-idp/backstage-plugin-orchestrator-form-react Patch
@janus-idp/backstage-plugin-orchestrator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@batzionb batzionb requested a review from a team as a code owner November 27, 2024 19:48
Copy link

sonarcloud bot commented Nov 27, 2024

Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having spaghetti rather on a plate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants