Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add a flag to relax version checks #2589

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

schultzp2020
Copy link
Member

This change adds an --ignore-version-check flag to the CLI to allow for selectively ignoring the semver check the CLI performs when evaluating the plugin package dependencies. This can be used to work around issues where a plugin has not been updated for awhile but it is known to work because it relies on interfaces and functions that have not changed.

duplicate of #2586 because GitHub is being funny.

This change adds an `--ignore-version-check` flag to the CLI to allow
for selectively ignoring the semver check the CLI performs when
evaluating the plugin package dependencies.  This can be used to work
around issues where a plugin has not been updated for awhile but it is
known to work because it relies on interfaces and functions that have
not changed.

Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: d319f69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@janus-idp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Dec 3, 2024

@schultzp2020
Copy link
Member Author

/cherry-pick release-1.4

@openshift-cherrypick-robot

@schultzp2020: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020 schultzp2020 merged commit 2acb6e0 into main Dec 3, 2024
13 of 14 checks passed
@schultzp2020 schultzp2020 deleted the relax-semver-check branch December 3, 2024 21:18
@openshift-cherrypick-robot

@schultzp2020: new pull request created: #2590

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gashcrumb
Copy link
Member

For completeness this fixes RHIDP-5141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants