Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose application and system metrics on the same port #2039

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

JessicaJHee
Copy link
Member

@JessicaJHee JessicaJHee commented Dec 2, 2024

Description

Previously there was a limitation with the OpenTelemetry adoption:

**Note**: Due to a limitation, the host and application metrics are exposed on separate ports. 
This is to be improved by making all metrics accessible on the same port (9464) in a future release. 
  • This PR addresses this issue and now all metrics (both application and system) are exposed on the same port (9464).

This improved implementation is recommended by this.

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Verify that system and Backstage specific application metrics are both present at http://localhost:9464/metrics

@JessicaJHee JessicaJHee requested a review from a team as a code owner December 2, 2024 20:04
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jessicajhee. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JessicaJHee JessicaJHee changed the title Expose application and system metrics on the same port chore: expose application and system metrics on the same port Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Signed-off-by: Jessica He <jhe@redhat.com>
Signed-off-by: Jessica He <jhe@redhat.com>
Copy link
Contributor

github-actions bot commented Dec 9, 2024

@kim-tsao
Copy link
Member

kim-tsao commented Dec 9, 2024

/test e2e-tests

2 similar comments
@kim-tsao
Copy link
Member

/test e2e-tests

@subhashkhileri
Copy link
Member

/test e2e-tests

Copy link

openshift-ci bot commented Dec 10, 2024

@JessicaJHee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 2d56b50 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kim-tsao
Copy link
Member

Force merging, since e2e test failures are unrelated and this change is already in 1.4

@kim-tsao kim-tsao merged commit e0c03b9 into janus-idp:main Dec 10, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants