-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expose application and system metrics on the same port #2039
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
06dd352
to
e3e8909
Compare
Signed-off-by: Jessica He <jhe@redhat.com>
Signed-off-by: Jessica He <jhe@redhat.com>
e3e8909
to
2d56b50
Compare
The image is available at: |
/test e2e-tests |
2 similar comments
/test e2e-tests |
/test e2e-tests |
@JessicaJHee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Force merging, since e2e test failures are unrelated and this change is already in 1.4 |
Description
Previously there was a limitation with the OpenTelemetry adoption:
This improved implementation is recommended by this.
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Verify that system and Backstage specific application metrics are both present at http://localhost:9464/metrics