chore(ci): fix k8s jobs, fix $DIR, better shebang #2074
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albarbaro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
|
The image is available at: |
zdrapela
force-pushed
the
openshift-ci-refactor-test
branch
from
f494076 to
20e6195
Compare
|
The image is available at: |
|
The image is available at: |
|
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update aks.sh Fix Fix configmap More fixes
zdrapela
force-pushed
the
openshift-ci-refactor-test
branch
from
7fee612 to
de0cdf4
Compare
|
After recently merged PRs the k8s jobs are broken again. |
|
The image is available at: |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
$dirused instead$DIR, presumably causing failures in nightly jobs and PR checks.#!/bin/bashshebang in CI files. This is appropriate for how the scripts are written and is recommended by https://github.com/koalaman/shellcheck. Also incorporate more improvements from ShellCheck.Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer