Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] fix gitlab-org wrapper #2116

Draft
wants to merge 2 commits into
base: release-1.3
Choose a base branch
from

Conversation

kadel
Copy link
Member

@kadel kadel commented Dec 17, 2024

Description

fixes missing embedded dependency in gitlab-org plugin

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Dec 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kadel. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -31,9 +31,10 @@
"test": "backstage-cli package test --passWithNoTests --coverage",
"clean": "backstage-cli package clean",
"clean-dynamic-sources": "yarn clean && rm -Rf node_modules",
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-catalog-backend-module-gitlab-org --override-interop default --no-embed-as-dependencies"
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-catalog-backend-module-gitlab-org --embed-package @backstage/plugin-catalog-backend-module-gitlab --override-interop default --no-embed-as-dependencies"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old CLI behavior being used here i.e. --embed-as-code, which is interesting I would have thought this would show a different kind of error at runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some strange things that are going on in this. When I tried to remove --no-embed-as-dependencies I get Error: Unable to validate plugin entry points: TypeError: util_endpoints_2.EndpointCache is not a constructor
I was unable to figure out why. But we are backporting fixes here, so I am not convinced that we should change this here. In 1.4 it already uses the new behavior.

@kadel kadel force-pushed the release-1.3-fix-gitlab-org branch from 1de535b to cb137e3 Compare December 18, 2024 09:23
Copy link

sonarcloud bot commented Dec 18, 2024

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2116!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants