-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] fix gitlab-org wrapper #2116
base: release-1.3
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -31,9 +31,10 @@ | |||
"test": "backstage-cli package test --passWithNoTests --coverage", | |||
"clean": "backstage-cli package clean", | |||
"clean-dynamic-sources": "yarn clean && rm -Rf node_modules", | |||
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-catalog-backend-module-gitlab-org --override-interop default --no-embed-as-dependencies" | |||
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-catalog-backend-module-gitlab-org --embed-package @backstage/plugin-catalog-backend-module-gitlab --override-interop default --no-embed-as-dependencies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the old CLI behavior being used here i.e. --embed-as-code
, which is interesting I would have thought this would show a different kind of error at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some strange things that are going on in this. When I tried to remove --no-embed-as-dependencies
I get Error: Unable to validate plugin entry points: TypeError: util_endpoints_2.EndpointCache is not a constructor
I was unable to figure out why. But we are backporting fixes here, so I am not convinced that we should change this here. In 1.4 it already uses the new behavior.
1de535b
to
cb137e3
Compare
|
The image is available at: |
Description
fixes missing embedded dependency in gitlab-org plugin
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer