Skip to content

Commit

Permalink
POWER: fix `TRPPC64CodeGenerator >> #virtualRegistersReadByProcessorI…
Browse files Browse the repository at this point in the history
…nstruction:do:`

Fix slip in `virtualRegistersReadByProcessorInstruction:do:` where registers in
field named `rs` were simply ignored.

Arguably, current way of determining what registers are read and assigned
by an instruction is stupid. We really should use instruction semantics
and extract this information from there.
  • Loading branch information
janvrany authored and shingarov committed Nov 28, 2023
1 parent c1e26b1 commit ea8db6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Tinyrossa-POWER/TRPPC64CodeGenerator.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ TRPPC64CodeGenerator >> virtualRegistersReadBy: instruction do: block [
].

instruction externalBindings keysAndValuesDo: [ :name :value |
(#('ra' 'rb' 'rc') includes: name) ifTrue: [
(#('ra' 'rb' 'rc' 'rs') includes: name) ifTrue: [
(value isBitVector and: [ value isSymbolic and: [ value isConstant ] ]) ifTrue: [
| vReg |

Expand Down

0 comments on commit ea8db6c

Please sign in to comment.