Use parametrized tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes old bugs in shells caused (probably) by renaming instance variables.
This commit introduces POWER-specific `TRPPCRegister` class. The main reason is that different tools use different register names: * Tinyrossa (as well as Testarossa) use `gr0`, `gr1` for GPRs, * GDB uses just `r0`, `r1` and so on and * in assembly (and ArchC) plain `0`, `1` is used. Having a custom subclass allows for having multiple methods returning register names suitable for given tool.
This commit implements `#call` and `#call:` to reduce code duplication in tests. These methods care for injecting the code, setting up parameters (in registers) and extracting return value (from return register). All this is done in target and linkage neutral way, though some extra support in linkages is needed. In order to do that, shell objects now hold on whole compilation rather than just the target.
This commit turns `TRCompilationTestCase` to parametrized testcase without changing tests themselves.
This commit update RISC-V compilation tests to use new shell helper methods introduced in previous commit.
This commit update POWER compilation tests to use new shell helper methods introduced in previous commit.
...to reduce code duplication. Tests that do now work on all targets are selectively skipped. This has the nice side-effect of documenting what's missing in particular for particular architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.