Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: by default lint all dirs, not just src and test #914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agilgur5
Copy link
Collaborator

Description

  • BREAKING: change the default lint args from 'src test' to './'

  • this is the same arg that's used internally and there isn't really a
    reason to skip some files arbitrarily; it's best practice to lint
    everything

  • this also lines up with changes to make tsc type-check all files,
    instead of just 'src' and 'types'

Tags

Notes

This is a breaking change. While it probably affects few users due to the fact that it gives a warning when nothing is specified, it is still breaking. Would make sense to add in v0.16.0 to go with the other ESLint / formatting changes.

- BREAKING: change the default lint args from 'src test' to './'

- this is the same arg that's used internally and there isn't really a
  reason to skip some files arbitrarily; it's best practice to lint
  everything
- this also lines up with changes to make `tsc` type-check all files,
  instead of just 'src' and 'types'
@agilgur5 agilgur5 added the version: minor Increment the minor version when merged label Oct 27, 2020
@vercel

This comment has been minimized.

Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pretty small change 👍

Now to wait some time before this can actually be merged...

@agilgur5
Copy link
Collaborator Author

CI is failing because GitHub Actions appears to be down per the logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant