Merge pull request #401 from jaredwray/fixing-linting-on-parameter-pr…

…operties fixing linting on parameter properties
jaredwray · Dec 6, 2024 · ba07da4 · ba07da4
2 parents 936e51b + d1811ea
commit ba07da4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -56,7 +56,6 @@
   "xo": {
     "rules": {
       "@typescript-eslint/naming-convention": 0,
-      "@typescript-eslint/parameter-properties": 0,
       "@typescript-eslint/no-unsafe-call": 0,
       "@typescript-eslint/no-unsafe-assignment": 0,
       "@typescript-eslint/no-unsafe-return": 0,

diff --git a/src/providers/aws-ses.ts b/src/providers/aws-ses.ts
@@ -6,6 +6,7 @@ export class AWSSES implements ProviderInterface {
 	client: SESClient;
 	name = 'aws-ses';
 	type = AirhornProviderType.SMTP;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {

diff --git a/src/providers/aws-sms.ts b/src/providers/aws-sms.ts
@@ -6,6 +6,7 @@ export class AWSSMS implements ProviderInterface {
 	client: SNS;
 	name = 'aws-sms';
 	type = AirhornProviderType.SMS;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {

diff --git a/src/providers/aws-sns.ts b/src/providers/aws-sns.ts
@@ -6,6 +6,7 @@ export class AWSSNS implements ProviderInterface {
 	client: SNS;
 	name = 'aws-sns';
 	type = AirhornProviderType.MOBILE_PUSH;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
 	region?: string;
 
 	constructor(region?: string) {

diff --git a/src/providers/firebase-messaging.ts b/src/providers/firebase-messaging.ts
@@ -8,7 +8,8 @@ export class FirebaseMessaging implements ProviderInterface {
 	name = 'firebase-messaging';
 	type = AirhornProviderType.MOBILE_PUSH;
 
-	private readonly cert: string;
+	// eslint-disable-next-line @typescript-eslint/parameter-properties
+	cert: string;
 
 	constructor(cert: string) {
 		this.cert = cert;

diff --git a/test/testing-data.ts b/test/testing-data.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/parameter-properties */
 import {AirhornTemplate, AirhornTemplateText} from '../src/template.js';
 
 export class TestingData {