Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google pub/sub updates and fixes #362

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Sep 12, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
google pub/sub updates and fixes

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 99.15%. Comparing base (db50a0d) to head (91a29ba).

Files with missing lines Patch % Lines
src/airhorn.ts 38.46% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #362      +/-   ##
===========================================
- Coverage   100.00%   99.15%   -0.85%     
===========================================
  Files           20       20              
  Lines          890      945      +55     
  Branches       208      215       +7     
===========================================
+ Hits           890      937      +47     
- Misses           0        8       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit 14e15b0 into main Sep 15, 2024
3 of 4 checks passed
@jaredwray jaredwray deleted the google-pub/sub-updates-and-fixes branch September 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant