Skip to content

Commit

Permalink
Update performance figures
Browse files Browse the repository at this point in the history
  • Loading branch information
@jarun
jarun committed May 11, 2017
1 parent a310176 commit 549fa4b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ nnn v1.1
News
- Introducing nlay - a highly customizable bash script to handle media type
- nnn is on [Homebrew](http://braumeister.org/formula/nnn) now
- RPM packages for CentOS 7 and Fedora 24
- RPM packages for CentOS 7 and Fedora 24 generated on release

Modifications
- *Search-as-you-type* support
What's in?
- *Search-as-you-type*
- Unicode support
- Option `-S` to start in disk usage analyzer mode
- Show media information (using mediainfo)
Expand Down
14 changes: 7 additions & 7 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,21 @@ Have fun with it! PRs are welcome. Check out [#1](https://github.com/jarun/nnn/i

### Performance

nnn vs. ncdu memory usage while listing an external disk with 13,790 files in disk usage analyzer mode:
nnn vs. ncdu memory usage while listing 438767 files in disk usage analyzer mode:

```
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
31163 vaio 20 0 65508 53980 2320 S 0.0 1.1 0:01.96 ncdu /
28863 vaio 20 0 21348 7812 2476 S 0.0 0.2 0:01.75 nnn -d
22515 vaio 20 0 60348 48712 2240 S 0.0 0.6 0:01.11 ncdu /
22574 vaio 20 0 17588 4320 2584 S 0.3 0.1 0:00.44 nnn -d /
```

nnn vs. mc vs. ranger memory usage while viewing a directory with 10,178 files, sorted by size:
nnn vs. mc vs. ranger memory usage while viewing a directory with 1500 files:

```
PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
22465 vaio 20 0 233956 192136 7896 S 0.0 3.9 0:05.31 /usr/bin/python -O /usr/bin/ranger
20369 vaio 20 0 64664 10980 6888 S 0.0 0.2 0:00.70 mc
28863 vaio 20 0 19876 6436 2620 S 0.0 0.1 0:00.19 nnn -d
22614 vaio 20 0 67848 25960 7880 S 0.0 0.3 0:00.32 /usr/bin/python -O /usr/bin/ranger /usr/bin/
22700 vaio 20 0 62320 8384 6516 S 0.0 0.1 0:00.01 mc /usr/bin
22646 vaio 20 0 17608 4016 2380 S 0.0 0.0 0:00.03 nnn -d /usr/bin/
```

### Installation
Expand Down

17 comments on commit 549fa4b

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmwangx @shaggytwodope @szlin nnn v1.1 released!

@szlin
Copy link
Collaborator

@szlin szlin commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of nnn has been packaged and pushed into Debian sid archive.

@professorjamesmoriarty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarun aur and ppa updated. I did run into an issue however. So as you may know some distros package ncurses differently. And as such cause some otherwise odd issues. On ubuntu no modifications are needed to build. However on Arch there is no <ncursesw/curses.h>, as a temp fix I've added a sed to the package build file: sed -i -e "s#<ncursesw/curses.h>#<curses.h>#g" $srcdir/$pkgname-$pkgver/nnn.c.

This should be a temp solution for now and no major effect. But may effect other distros. I'm wondering if pkg-config would be a possible solution?

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check this when I'm back home.

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we could use a distro-specific #include too.

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for taking care of this for now! 👍

@szlin
Copy link
Collaborator

@szlin szlin commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since nnn is FTBFS on non-Linux, there is a Debian user provides a method to solve FTBFS issue on hurd-i386 and kfreebsd~* 1.

I think it's acceptable, would you mind checking on it?

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szlin I think this is fine. Please raise the PR. But @shaggytwodope I don't think this will solve our issue on Arch, right? Is there any macro to identify Arch?

Also, I have made a blunder and missed updating the version to 1.1 in Makefile.generic. What do you suggest to take care of this?

@professorjamesmoriarty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarun In an attempt to solve this, I've turned to pkg-config. You can see here my rather simple fix. This builds without fail on both arch and ubuntu machines. This has not been tested for any other platforms, as at this time I have no access to other platforms. While it does bring a new build dep, pkg-config to my understanding is available across the board.

I'd love any feedback as to why this may not work, or even cause issues for the bsd and mac users. @szlin this should address bsd isssues. Unless I've over looked something.

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaggytwodope I think it solves all the issues we have. I have worked on trimmed down Linux-based embedded systems (a decade back) without pkg-config but I think the case is archaic now and not our target platform.

@zmwangx do you see any issues? On Homebrew?

@fennm
Copy link
Contributor

@fennm fennm commented on 549fa4b May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dockerfile will likely need to be updated to include pkg-config, but any such issues should be ferreted out by travis on a real PR.

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fennm once we decide to go with this I'ld request @shaggytwodope to raise the PR.

@zmwangx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with curses here as we've discussed before. (You know, Makefile has a Darwin branch.)

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! @shaggytwodope please raise the PR.

@zmwangx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see you were talking about pkg-config. Sure, using pkg-config in Makefile shouldn't be a problem on macOS with any configuration: with or without pkg-config, with stock ncurses 5.x or third-party ncurses 6.x.

@szlin
Copy link
Collaborator

@szlin szlin commented on 549fa4b May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarun I will check the PR from 1, it perhaps also fixes the issue on hurd and kfreebsd

@jarun
Copy link
Owner Author

@jarun jarun commented on 549fa4b May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Lin!

Please sign in to comment.