Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New Plugin #1900

Closed
wants to merge 2 commits into from
Closed

Added New Plugin #1900

wants to merge 2 commits into from

Conversation

Zazucki
Copy link

@Zazucki Zazucki commented Jun 24, 2024

Added upl0ad: Upload files to 0x0.st

I'm open to alternative names, or integrating this into the upload plugin.

@jarun
Copy link
Owner

jarun commented Jun 28, 2024

Please integrate with the existing upload plugin.

@Zazucki
Copy link
Author

Zazucki commented Jul 2, 2024

ix.io and ffsend services are both deprecated, but file.io still works.
file.io allows 2 GB, 0x0.st max filesize is 512 MB.
Is it fine to remove ffsend and ix.io and replace with 0x0.st, leaving file.io logic for larger files?

@KlzXS
Copy link
Collaborator

KlzXS commented Jul 5, 2024

You are right, those two don't work anymore. Remove ffsend, it's been years and it's officially discontinued. See what that new Thunderbird Send stuff is if you can. Keep ix for now, maybe it comes back.

Other than that just add the new service and offer the user to choose which one to use. Don't force a default.

@jarun
Copy link
Owner

jarun commented Jul 16, 2024

@Zazucki can you please address the comments?

@Zazucki
Copy link
Author

Zazucki commented Jul 16, 2024

I have seen nothing about Thunderbird Send since this podcast from September 27, 2023. Specifically this part. I doubt it'll be available for use until they officially release the modernized Thunderbird.

ix.io has been down since December of last year, I'm not sure how long is acceptable to wait.
Also, according to the most recent live version of ix.io:

If you are distributing software that uses this automatically, talk to me first.

Was this ever done when initially implementing the plugin?

Other than the Client, it seems to only have a few more features over 0x0.st, like color highlighting.

I'm fine with implementing the changes into the original upload plugin, but it may take me some time to get around to it.

@jarun
Copy link
Owner

jarun commented Jul 17, 2024

OK, take your time. Remove ix.io as well.

@Zazucki
Copy link
Author

Zazucki commented Jul 17, 2024

Here's a first attempt, it's rough but it works. Still need to test with bad filenames.

https://gist.github.com/Zazucki/d3d843cd26053f6ff38e16082b40b4af

I know line 16 is a mess, but xargs complains if I try to split the line. Also, this was the only way I found it to work with selections.

If it's not clear, please ask questions.

edit: forgot to mention, you can add -t to xargs command to show what file corresponds to which link via showing the command xargs is running, but it makes the output kinda messy.

@jarun
Copy link
Owner

jarun commented Jul 19, 2024

@Zazucki make sure to run chellcheck.
@KlzXS can you please review?

@Zazucki
Copy link
Author

Zazucki commented Jul 19, 2024

Shellcheck only found 1 problem, I fixed and updated the gist.

@jarun
Copy link
Owner

jarun commented Jul 20, 2024

@N-R-K please review if you have the time.

@KlzXS
Copy link
Collaborator

KlzXS commented Jul 21, 2024

I left a comment on the gist @Zazucki.

@N-R-K
Copy link
Collaborator

N-R-K commented Jul 25, 2024

Do you guys know any pastebin which has syntax highlighting and can auto-detect language? I was looking at https://bpa.st but it doesn't seem to auto-detect filetype.

@Zazucki
Copy link
Author

Zazucki commented Jul 25, 2024

I used to use hastebin for that but I heard Toptal ruined it.

There's some promising things here you can look through:
https://alternativeto.net/software/pastebin/

N-R-K added a commit to N-R-K/nnn that referenced this pull request Jul 25, 2024
this removes ix.io and ffsend since they are no longer active.

binary files are uploaded to file.io as before. selections are
now tar-balled and uploaded to file.io.

text files are uploaded to 0x0.st

Closes: jarun#1900
N-R-K added a commit to N-R-K/nnn that referenced this pull request Jul 25, 2024
this removes ix.io and ffsend since they are no longer active.

binary files are uploaded to file.io as before. selections are
now tar-balled and uploaded to file.io.

text files are uploaded to 0x0.st

Closes: jarun#1900
@jarun jarun closed this in #1917 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants