Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - updateCards requires insertNewCardID #133

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mkraenz
Copy link
Contributor

@mkraenz mkraenz commented Aug 2, 2024

Hi, thanks for the introduction of note updates. It was my pain point number 1 with the extension for a long time. So thank you and the contributors!

Changes

  • docs: when enabling anki.md.updateCards, add remark that anki.md.insertNewCardID should be enabled, too.

Background

When migrating to updating notes however, I ran into Error: ['cannot create note because it is a duplicate'].

Using the docs to set updateCards to true did not solve the issue. Only checking the gh issues and reading about the insertNewCardID flag in #122 I noticed what's wrong.

So apparently anki.md.updateCards requires anki.md.insertNewCardID.

If this is a wrong interpretation of what went wrong, feel free to close this PR.

Note

This might be a migration issue. I installed the extension a long time ago. I am unaware of whether anki.md.insertNewCardID is set to true by defaults for new installs or not.

@jasonwilliams
Copy link
Owner

jasonwilliams commented Aug 2, 2024

Hi @mkraenz

Thanks for raising this, and thank you for the contribution.
It looks like we may need to eventually fold those options into one as that will be confusing.

Originally the plan was to have updateCards be one setting, then the update strategy be a different setting, but in the end we only had 1 update strategy (which is to add a noteID to the item). As we don't plan to have any other strategy for persistence we might be able to just remove the second option (anki.md.insertNewCardID) altogether.

I've raised an issue for this here: #134

@jasonwilliams jasonwilliams merged commit 415637a into jasonwilliams:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants