Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide dependencies to result menu #5046

Open
wants to merge 4 commits into
base: stable
Choose a base branch
from

Conversation

RensDofferhoff
Copy link
Contributor

Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2254

A lot of changes for something so small.

@RensDofferhoff RensDofferhoff changed the title Add hide dependencies to resultmenu Add hide dependencies to result menu Mar 8, 2023
Desktop/results/resultmenumodel.cpp Outdated Show resolved Hide resolved
@boutinb
Copy link
Contributor

boutinb commented Apr 18, 2023

Your fix does not work correctly. If I open a Descriptive analysis, I click on 'Show dependencies' for the Descriptives Statistics table, then Hide dependencies. Afterwards I select one variable, then the Variables & Split get the green broder:

Screenshot 2023-04-18 at 12 26 33

Copy link
Contributor

@JorisGoosen JorisGoosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hide Dependencies" should only be shown for the one that is actually showing dependencies...

See screenshot with two analyses or two jaspObjects:
image

image

The shown dependencies are for "Descriptive Statistics" table in both cases.

And perhaps I want to see more dependencies for more objects?
Now I have to click twice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants