Set the control width of Dropdown by setting the fieldWidth property #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be reviewed and merged? |
boutinb
force-pushed
the
dropDownWithFixedWidth
branch
4 times, most recently
from
f933887
to
4107402
Compare
Yes it can be reviewed now |
This is now easily addable to any qml control by adding the property controlXOffset and applying it to the relevant leftPadding
JorisGoosen
approved these changes
Sep 12, 2024
JorisGoosen
added a commit
that referenced
this pull request
Sep 30, 2024
…5586) * Add fieldWidth property to Dropdown * let dropdown participate in aligning labelwidths This is now easily addable to any qml control by adding the property controlXOffset and applying it to the relevant leftPadding * use new aligning in prefsUI --------- Co-authored-by: Joris Goosen <Joris@JorisGoosen.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fieldWidth property to Dropdown, to fix the width of the dropdown. If the length of the value is then smaller, it should be elided with '...'. The popup menu should be as wide as necessary so that all values are clearly seen.
A new test Test Dropdown has been added to the Test module.
Fixes jasp-stats/jasp-issues#2404