Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix tooltip in the checkBox and RadioButton #5623

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Jul 14, 2024

Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2525
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2366

The reason is that sometimes the checkbox and radioButton cannot actually detect the mouse hover event.

@shun2wang shun2wang requested a review from boutinb July 14, 2024 09:19
@boutinb boutinb force-pushed the fixTooltips branch 2 times, most recently from 224d254 to eb7804b Compare September 12, 2024 11:58
@boutinb
Copy link
Contributor

boutinb commented Sep 12, 2024

@shun2wang There was already a tooltip in jaspControl but it did not work. Handling attached property in c++ can be tricky: the attached property can be called directly if there is an import statement in the QML file without label. But by setting the tooltip directly in the MouseArea it works perfectly.

@boutinb
Copy link
Contributor

boutinb commented Sep 12, 2024

I have added also a test in the jaspTestModule.

@shun2wang
Copy link
Contributor Author

shun2wang commented Sep 12, 2024

Great! so then we should remove all tooltip settings from other jaspControls component and just reuse it from C++ side?

I rebased this PR to head.

@shun2wang
Copy link
Contributor Author

@boutinb This should get into 0.19.2 I gusess.

@boutinb boutinb merged commit d661a37 into jasp-stats:development Oct 18, 2024
1 check passed
@shun2wang shun2wang deleted the fixTooltips branch October 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants