Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Sort labels bug and other label handling issues #5630

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Jul 18, 2024

This solves several issues:

  • The "Auto Sort Label per value" setting (true per default in the preferences) is not saved in the database. Now this setting is saved in the database and thus also in the JASP file.
  • The "Auto Sort Label per value" works also for non numeric values. Now the labels are per default also alphabetically ordered.
  • The Variable Window does not show always the selected column, especially when navigating in the Data view with the keyboard: the Variable Window was showing still the old selected column.
  • The up/down/reverse buttons were not visible or/and enabled in the right way. Now if Auto Sort is on, all the other buttons are removed, except the 'Reverse order of all numerical values' if at least 2 labels have numerical values. If Auto Sort is off, all other buttons are displayed, and are enabled only if they really can change the order (the up button is disabled for example if the the selected row is the first one).

This solves several issues:
. The "Auto Sort Label per value" setting (true per default in the preferences) is not saved in the database. Now this setting is saved in the database and thus also in the JASP file
. The "Auto Sort Label per value" works also for non numeric values. Now the labels are per default also alphabetically ordered.
. The Variable Window does not show always the selected column, especially when navigating in the Data view with the keyboard: the Variable Window was showing still the old selected column.
. The up/down/reverse buttons were not visible or/and enabled in the right way. Now if Auto Sort is on, all the other buttons are removed, except the 'Reverse order of all numerical values' if at least 2 labels have numerical values. If Auto Sort is off, all other buttons are displayed, and are enabled only if they really can change the order (the up button is disabled for example if the the selected row is the first one).
@boutinb boutinb changed the title Auto Sort labels does bug and other label handling issues Auto Sort labels bug and other label handling issues Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant