-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: ribbon menu translations hot update #5633
Conversation
Really nice! |
Well, it should be updated all because it block build on Linux. Or someone can update all packages in |
@shun2wang current pkgdepends does not build for you? |
yeah, you can also find it from any failed actions: https://github.com/jasp-stats/jasp-desktop/actions/runs/10598393408 old packages has build problems with gcc version maybe. |
Interesting! I have not seen these issues on my machines @boutinb The updates are alright |
|
||
loadModules(); | ||
} | ||
|
||
void RibbonModel::addRibbonButtonModelFromDynamicModule(Modules::DynamicModule * module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right way to do this. The loadModules(I) will recreate the modules, make some memory leakage (_entriesInsert, _entriesDelete, etc...), this is quite dangerous I think.
I don't understand why the 'special ribbon entries' are not translated, and the module ribbon buttons are. I remember that @JorisGoosen knew why. Maybe it is better to wait for his return of his holidays.
Thanks for making this @shun2wang but Ive made another PR for this at #5653 |
Fix: https://github.com/jasp-stats/INTERNAL-jasp/issues/2372
So we just remove/renew the menu ribbon button to "reload" it to apply the translations.