Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sem data example #5637

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Conversation

juliuspfadt
Copy link
Contributor

No description provided.

@juliuspfadt juliuspfadt changed the title add sem data example and clean up a bit in the data lib add sem data example, change variable type sin factorsForm Aug 12, 2024
@juliuspfadt juliuspfadt changed the title add sem data example, change variable type sin factorsForm add sem data example Aug 12, 2024
@juliuspfadt
Copy link
Contributor Author

I didn't mean to update all these other files... can I revert that somehow?

@shun2wang
Copy link
Contributor

The most simple way is drop the last commit and re-add the ADD symptoms data files.

  1. git reset --hard HEAD~1
  2. add the data files
  3. rebase upstreams head: git rebase upstream/development
  4. froce push to upstream

@juliuspfadt juliuspfadt force-pushed the development branch 3 times, most recently from 8a5f3a6 to 8a34782 Compare August 14, 2024 07:10
@juliuspfadt
Copy link
Contributor Author

Thanks, I think I managed somehow :)

@boutinb
Copy link
Contributor

boutinb commented Sep 5, 2024

Hi @juliuspfadt I have added the json files so that the example will be seen in JASP menu. You still to add a description. There are translations for dutch, german and chinese. I think you can do the dutch and german translations easily. Maybe for the chinese translation, @shun2wang can help you?

Copy link
Contributor

@shun2wang shun2wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will updated the translate.

there is no description should be translated I think? and I woud find a way to translate them with our Weblate hosts later.

@juliuspfadt
Copy link
Contributor Author

I added the descriptions.

@boutinb
Copy link
Contributor

boutinb commented Sep 6, 2024

Ok, I will updated the translate.

there is no description should be translated I think? and I woud find a way to translate them with our Weblate hosts later.

The Data Library description is not yet in WebLate. This should be done before we have Module store. But for the time being, if you can translate the description (Julius just added it) in index_zh_Hans.json, then it will be translated in Chinese.

Resources/Data Sets/index_zh_Hans.json Outdated Show resolved Hide resolved
@shun2wang
Copy link
Contributor

shun2wang commented Sep 6, 2024

The Data Library description is not yet in WebLate.

Yes I know.I mean I'm looking for a programmatic mechanism from json to po to translate the text, but that has nothing to do with this PR, I just think there might be a way to do it.

Co-authored-by: Shun Wang <shuonwang@gmail.com>
@juliuspfadt
Copy link
Contributor Author

I suppose @boutinb could merge it?

@boutinb
Copy link
Contributor

boutinb commented Sep 9, 2024

Yes I know.I mean I'm looking for a programmatic mechanism from json to po to translate the text, but that has nothing to do with this PR, I just think there might be a way to do it.

I think we could add the names and the descriptions of the Library files in Description.qml with a new item DataLibrary with actually the same properties as the current index.json file, plus an extra property to tell whether the file should be present also in one or more books:

DataLibrary
{
          name: qsTr("Emily Rosa")
          path: "Emily Rosa.jasp"
          description: qsTr("Correct and incorrect decisions from therapeutic touch practitioners in Emily Rosa's famous experiment. \"In the initial trial, the subjects stated the correct location of the investigator's hand in 70 (47%) of 150 tries.\" <br><br> The example JASP file demonstrates the use of a Bayesian binomial test.<br><br> <i>Data set reconstructed from the summary information in Rosa et al. (1998).<\/i>")
          kind: "file",
          associated_datafile: "Emily Rosa.csv"
          books: ["Field"]
}

The books should be references to items that could be defined for example in DataLibrary.qml

Book
{
    name: "Field"
    label: qsTr("Field - Discovering Statistices"
    description: qsTr("...")
}

In this way all the string of the Data Library will be automatically in WebLate.

@boutinb boutinb merged commit 3ef092b into jasp-stats:development Sep 9, 2024
@shun2wang
Copy link
Contributor

Yes, good idea, actually the Weblate does support .json as translation source but I dont know how it works, maybe you can have a look? which may work without refactor I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants