-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sem data example #5637
add sem data example #5637
Conversation
611620d
to
f53aad2
Compare
aa70d92
to
f53aad2
Compare
I didn't mean to update all these other files... can I revert that somehow? |
The most simple way is drop the last commit and re-add the
|
8a5f3a6
to
8a34782
Compare
Thanks, I think I managed somehow :) |
Hi @juliuspfadt I have added the json files so that the example will be seen in JASP menu. You still to add a description. There are translations for dutch, german and chinese. I think you can do the dutch and german translations easily. Maybe for the chinese translation, @shun2wang can help you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will updated the translate.
there is no description should be translated I think? and I woud find a way to translate them with our Weblate hosts later.
2ae71af
to
4740040
Compare
4740040
to
4490a70
Compare
I added the descriptions. |
The Data Library description is not yet in WebLate. This should be done before we have Module store. But for the time being, if you can translate the description (Julius just added it) in index_zh_Hans.json, then it will be translated in Chinese. |
Yes I know.I mean I'm looking for a programmatic mechanism from json to po to translate the text, but that has nothing to do with this PR, I just think there might be a way to do it. |
Co-authored-by: Shun Wang <shuonwang@gmail.com>
I suppose @boutinb could merge it? |
I think we could add the names and the descriptions of the Library files in Description.qml with a new item DataLibrary with actually the same properties as the current index.json file, plus an extra property to tell whether the file should be present also in one or more books:
The books should be references to items that could be defined for example in DataLibrary.qml
In this way all the string of the Data Library will be automatically in WebLate. |
Yes, good idea, actually the Weblate does support |
No description provided.