Add function to remove environments tracked by ggplot2 #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JorisGoosen this is an alternative/ global approach for https://github.com/jasp-stats/INTERNAL-jasp/issues/1755
Two things to consider:
demoBad
ininst/examples/ex-removeEnvironments.R
). I'd argue that all code that breaks because of this is poorly written (and needs a rewrite).To quickly test this in JASP you can change this line
https://github.com/jasp-stats/jaspResults/blob/49dcd41be799272b69ee562e496ee57afaaf33fa/R/zzzWrappers.R#L509
into
and just dump the contents of
R/removeEnvironments.R
at the bottom of the file. Ugly, but otherwise you need to ensure that modules actually call the right jaspGraphs and all that...