Improve code style of generated stream classes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Konecny <zbynek1729@gmail.com>
kaikalur
reviewed
Aug 26, 2023
| **********************************************/ | ||
| /*-------------------------------------------- | ||
| * THE JAVA GRAMMAR SPECIFICATION STARTS HERE | ||
| *--------------------------------------------*/ |
There was a problem hiding this comment.
In javacc-8 we want to remove the java grammar completely out of the javacc grammar if possible.
There was a problem hiding this comment.
that sounds like agood improvement too, but in scope of this PR I only wanted to improve the code style of generated classes without changing their functionality.
|
Sounds good! Can you make sure some of the grammar tests run? Once you confirm we can merge it. Thanks! |
kaikalur
approved these changes
Aug 29, 2023
|
@kaikalur anything else needed before merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.