Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[key reuse] handle reuse of closed-over constants #20716

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[key reuse] handle reuse of closed-over constants #20716

merged 1 commit into from
Apr 11, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Apr 11, 2024

Fixes #20704

@jakevdp jakevdp requested a review from froystig April 11, 2024 19:09
@jakevdp jakevdp self-assigned this Apr 11, 2024
yashk2810
yashk2810 reviewed Apr 11, 2024
View reviewed changes
jax/_src/pjit.py Outdated Show resolved Hide resolved
@jakevdp jakevdp force-pushed the key-reuse-jit-fix branch 2 times, most recently from 47fde8d to 2546c59 Compare April 11, 2024 19:23
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Apr 11, 2024
@copybara-service copybara-service bot merged commit 4f9cb47 into jax-ml:main Apr 11, 2024
13 checks passed
@jakevdp jakevdp deleted the key-reuse-jit-fix branch April 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 left review comments

@froystig froystig froystig approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

key reuse detection fails for closed-over keys in JIT
4 participants
@jakevdp @froystig @yashk2810 @kokoro-team