Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib for profiler log_dir #22586

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Use pathlib for profiler log_dir #22586

merged 1 commit into from
Aug 19, 2024

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jul 23, 2024

@sharadmv Can you please enable a test run here?

@cool-RR
Copy link
Contributor Author

cool-RR commented Jul 28, 2024

Or maybe @yashk2810 ?

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Jul 30, 2024
@cool-RR
Copy link
Contributor Author

cool-RR commented Aug 17, 2024

@sharadmv Are we good for merging?

@sharadmv
Copy link
Collaborator

Yes thanks for the reminder

@sharadmv sharadmv added pull ready Ready for copybara import and testing and removed pull ready Ready for copybara import and testing labels Aug 19, 2024
@copybara-service copybara-service bot merged commit 1563897 into jax-ml:main Aug 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadmv sharadmv sharadmv approved these changes

Assignees
No one assigned
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cool-RR @sharadmv @kokoro-team