[ROCm] Fix run single gpu script to avoid duplicates #22924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruturaj4
force-pushed
the
rocm-jax-stable-2024_08_07
branch
2 times, most recently
from
11bb8f7
to
22be05b
Compare
superbobry
approved these changes
Aug 8, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
Ruturaj4
force-pushed
the
rocm-jax-stable-2024_08_07
branch
from
22be05b
to
644ac10
Compare
superbobry
approved these changes
Aug 8, 2024
|
@superbobry is this not merged yet? just closed? Could you please check? |
|
@Ruturaj4 — It looks like you closed this PR. Did you not mean to? |
|
@dfm Just reopened again, idk how that was closed! |
|
Thanks - can you rebase onto |
Done, thanks! |
|
@Ruturaj4 — Thanks! Please also squash the commits into one and we'll get this merged. |
Ruturaj4
force-pushed
the
rocm-jax-stable-2024_08_07
branch
from
c76224a
to
e06be54
Compare
|
@dfm thanks! I will keep in mind two squash commits in future. can you please approve? |
dfm
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@superbobry can you please review and merge? thanks!
The script will help improve our internal reporting.