Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PyUnstable_Module_SetGIL to PyInit_cpu_feature_guard #23130

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 19, 2024

This PR is based on #23129

Description:

  • Added PyUnstable_Module_SetGIL to PyInit_cpu_feature_guard to explicitly indicate the extension supports running with the GIL disabled.

Refs:

Context:

@vfdev-5 vfdev-5 requested a review from hawkinsp August 19, 2024 22:16
Copy link
Collaborator

@hawkinsp hawkinsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have commits for both PRs in this one.

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Aug 19, 2024
@copybara-service copybara-service bot merged commit d148ade into jax-ml:main Aug 20, 2024
14 checks passed
@vfdev-5 vfdev-5 deleted the nogil-cpu_feature_guard branch August 20, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants