[ROCm] Rocm62 fixes #23146
Merged
[ROCm] Rocm62 fixes #23146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ruturaj4
commented
Aug 20, 2024
Ruturaj4
commented
- Interactive causes bazel to output more useful info when running locally.
- Work around quirk with rocm version when it ends with 0.
- Ubu22 and higher have a package name conflict between the debian versions and the AMD provided versions.
- Use env variable to set compiler type.
|
@superbobry Could you please take a look? I will squash the commits once approved. |
|
@superbobry is OOO, but I'm happy to take a look. It all looks good to me - can you please squash! |
|
@dfm Done thanks! |
dfm
approved these changes
Aug 20, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
mrodden
reviewed
Aug 20, 2024
dfm
approved these changes
Aug 21, 2024
|
@Ruturaj4 — I'm sorry to say that there were unrelated issues with the builds yesterday. Could you rebase onto main (don't forget to squash!) one more time then we can merge? Thank you! |
|
@dfm no worries, at all! thanks so much! |
Interactive causes bazel to output more useful info when running locally. * Fix issue with rocm el8 repo urls Work around quirk with rocm version when it ends with 0 * Fix package name conflict Ubu22 and higher have a package name conflict between the debian versions and the AMD provided versions. * [ROCm] Use clang env
dfm
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.