-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: batched wording edits #23298
docs: batched wording edits #23298
Conversation
This was common and we typically just mean "summary."
Git history covers this better and automatically.
Mainly make titles/headings easier to read, by swapping code for words and not using headings as links.
Shorten the titles for derivative rules and manual parallelism, and go for canonical wording in the parallel programming intro (typically we "shard" data, and "partition" computation, as part of parallel programming).
@@ -34,11 +36,13 @@ Table of contents: | |||
# 🤯 0.9092974662780762 🤯 | |||
``` | |||
|
|||
Click [here](print_breakpoint) to learn more! | |||
[Read more](print_breakpoint). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider using a sphinx {ref}`target-name`
syntax for the cross-references in this file, rather than linking via the filenames. It would involve adding a target name at the top of each of the referenced files, similar to this jax-array-migration
target: https://github.com/google/jax/blob/ef33cf5acee2668b3e847aa19c91a52f6c18328d/docs/jax_array_migration.md#L1-L3
A benefit of this approach is that it automatically generates a hyperlink using the text from the referenced heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's useful in general. In this case I want the anchor text to say "read more," similar to what it did before this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Once small comment about using more robust cross-references.
This is a batch of individually minor edits that aim for easier/clearer reading and some decluttering of titles and headings (which hopefully also helps in indices and in our navigation panel).