-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JAX_LOGGING_LEVEL
configuration option
#23468
Merged
Merged
+282
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdyro
force-pushed
the
rdyro-add-logging-env
branch
4 times, most recently
from
September 6, 2024 17:59
bc55b7e
to
d6f30ab
Compare
skye
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to review the test more carefully still but some initial comments.
Also can you provide example command + output in the PR description? |
rdyro
force-pushed
the
rdyro-add-logging-env
branch
2 times, most recently
from
September 13, 2024 18:21
9850fa8
to
c1d920c
Compare
rdyro
force-pushed
the
rdyro-add-logging-env
branch
from
September 27, 2024 01:57
c1d920c
to
73a7f14
Compare
rdyro
force-pushed
the
rdyro-add-logging-env
branch
6 times, most recently
from
October 7, 2024 17:35
bddedd5
to
c58d7ad
Compare
skye
requested changes
Oct 8, 2024
rdyro
force-pushed
the
rdyro-add-logging-env
branch
from
October 10, 2024 21:43
61faa7c
to
6e94d48
Compare
skye
requested changes
Oct 12, 2024
rdyro
force-pushed
the
rdyro-add-logging-env
branch
2 times, most recently
from
October 21, 2024 16:27
3f07429
to
0d19948
Compare
rdyro
force-pushed
the
rdyro-add-logging-env
branch
3 times, most recently
from
November 4, 2024 17:09
ada7554
to
2decbf3
Compare
skye
approved these changes
Nov 5, 2024
rdyro
force-pushed
the
rdyro-add-logging-env
branch
from
November 5, 2024 17:25
2decbf3
to
1ed0bff
Compare
rdyro
force-pushed
the
rdyro-add-logging-env
branch
from
November 5, 2024 17:56
1ed0bff
to
04f2ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, setting
JAX_LOGGING_LEVEL=DEBUG
forgives
in the formatting style of already existing JAX module debugging:
jax_debug_log_modules
option.