[shape_poly] Improve handling of equality shape constraints #23470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
poly_fix_eq_constraints
branch
from
8c91ed7
to
148a961
Compare
This fixes several bugs in presence of equality constraints where the left-hand side is just a dimension variable. First, such constraints were not applied when parsing variables. Now, with a constraint `a == b` when we parse "a" we obtain `b`. Second, when we evaluate symbolic dimensions that contain dimension variables that are constrained to be equal to something else, we may fail to find the dimension variable in the environment because the environment construction has applied the constraints. We fix this by looking up the unknown dimension variable in the equality constraints. Fixes: jax-ml#23437 Fixes: jax-ml#23456
gnecula
force-pushed
the
poly_fix_eq_constraints
branch
from
148a961
to
0d8ffd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several bugs in presence of equality constraints where the left-hand side is just a dimension variable.
First, such constraints were not applied when parsing variables. Now, with a constraint
a == bwhen we parse "a" we obtainb.Second, when we evaluate symbolic dimensions that contain dimension variables that are constrained to be equal to something else, we may fail to find the dimension variable in the environment because the environment construction has applied the constraints. We fix this by looking up the unknown dimension variable in the equality constraints.
Fixes: #23437
Fixes: #23456