Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pylintrc file #23959

Closed
wants to merge 1 commit into from
Closed

Add .pylintrc file #23959

wants to merge 1 commit into from

Conversation

apivovarov
Copy link
Contributor

@apivovarov apivovarov commented Sep 26, 2024

The JAX project utilizes non-standard PEP 8 settings for indentation.

To validate Python files, we can leverage a .pylintrc configuration file.

For reference, the TensorFlow project has an existing .pylintrc file that outlines its settings.

This PR introduces a .pylintrc file for the JAX project, modeled after the configuration used in TensorFlow.

[FORMAT]

# Maximum number of characters on a single line.
max-line-length=80

# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
# tab).
indent-string='  '

Usage Example:

### check files in HEAD commit
git diff --name-only HEAD^ HEAD | xargs pylint

@jakevdp
Copy link
Collaborator

jakevdp commented Sep 26, 2024

Hi - thanks for the PR. We already have pylint configuration in pyproject.toml, and I'd prefer to keep all such configs in a single location

@jakevdp jakevdp self-assigned this Sep 26, 2024
@jakevdp
Copy link
Collaborator

jakevdp commented Sep 26, 2024

Also, a while ago we moved off pylint and now use ruff for formatting. It's set up as a pre-commit hook, though we only enable a few checks.

@apivovarov
Copy link
Contributor Author

Got it. Thank you for the info!

@apivovarov apivovarov closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants