Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pallas] Simplify OpsTest by skipping 64-bit tests on 32-bit environments #23960

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Sep 26, 2024

[Pallas] Simplify OpsTest by skipping 64-bit tests on 32-bit environments

This PR is similar to #23814.

Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using stack.enter_context(config.enable_x64(True)). This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments.

@copybara-service copybara-service bot force-pushed the test_679307748 branch 2 times, most recently from 014ae5d to 156ac97 Compare September 30, 2024 20:30
@copybara-service copybara-service bot force-pushed the test_679307748 branch 3 times, most recently from 9454d50 to b95e428 Compare October 8, 2024 00:27
@copybara-service copybara-service bot changed the title [Pallas] Simplify OpsExtraTest by skipping 64-bit tests on 32-bit environments [Pallas] Simplify OpsTest by skipping 64-bit tests on 32-bit environments Oct 8, 2024
…nments

This PR is similar to #23814.

Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments.
PiperOrigin-RevId: 683405197
@copybara-service copybara-service bot merged commit 6a958b9 into main Oct 8, 2024
@copybara-service copybara-service bot deleted the test_679307748 branch October 8, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant