Adding clang-format
to pre-commit YAML config.
#182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same clang-format version
v17.0.6
as XLA project:https://github.com/openxla/xla/blob/main/.github/workflows/clang_format.yml
@jakevdp I believe the project C++ codebase is small enough to directly add
clang-format
to pre-commit hooks. Beyond making sure every PR is well formatted, it also has the benefit of making sure everyone is using the same version (aligned on XLA codebase).