Temporarily disable free-threading build & multithread tests #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? We need an 0.5.0 release for Python 3.13 support, but the new multi-thread support still results in flaky tests due to some race conditions in both ml-dtypes and NumPy. After the 0.5.0 release we will plan to re-enable these and work on a longer-term fix.
jakevdp
force-pushed
the
no-multithread
branch
from
0b08020
to
abe1d89
Compare
hawkinsp
approved these changes
Sep 13, 2024
Yeah good point. I think since I already did it this way we'll just roll with it (unless something goes wrong in CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? We need an 0.5.0 release for Python 3.13 support, but the new multi-thread support still results in flaky tests due to some race conditions in both ml-dtypes and NumPy. After the 0.5.0 release we will plan to re-enable these and work on a longer-term fix.