Fix eigen::numext::signbit for MXFloat types (fp6/fp4) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Eigen implementation checks the highest bit (7) to determine if a number is signed.
For less-than-8-bit types, this is incorrect - so add the template specialization for these types.
Note that "eigen::numext::signbit" returns all-zero-bits for an unsigned input, and all-one-bits for signed input.
For 8-bit types, this is
0x00for unsigned and0xFFfor signed.Note: this was previously not picked up by the tests, as this project doesn't use the "eigen::numext::signbit" function, but other projects do (e.g. OpenXLA).