Fix rounded_from_bits casting in float8.h #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently XLA
bazel build //xla:literal_test
fails with error (Clang 18)Solution:
Narrowing conversions in an initializer list, is not allowed in C++11 and later without an explicit cast.
We need to explicitly cast the value to the target type (ToBits) to indicate that we are aware of the potential narrowing
@jakevdp Can you have a look?