Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Debian package #5

wants to merge 1 commit into from

Conversation

univerio
Copy link

@univerio univerio commented Oct 2, 2017

First of all, thanks for the awesome script!

I added configuration templates so that it can be managed by the built in Vyatta config system, i.e. so you can do

set service eap-proxy wan-interface eth0
set service eap-proxy router-interface eth2

to set up the proxy. I also packaged it into a deb for easy installation.

If you feel that this is out of scope for your repo, I don't mind keeping it as a fork.

@ShadwDrgn
Copy link

ShadwDrgn commented Dec 10, 2017

I assume this is a mistake as the two lines above would overwrite one another. I assume one of the lines should say router-interface. Also some README.md changes would be nice to explain how to compile this as a deb, and how to install it. :) I grabbed the premade deb from your repo. Thanks for the work.

@univerio
Copy link
Author

@ShadwDrgn You're absolutely right. I've edited the post. (I had also written eap-service when it should have been eap-proxy.) I've also updated the README with build and installation instructions. I've left the PR alone though, not sure whether he'd want to merge the README changes. (It's also been two months, so I'm not sure he wants to merge these changes at all, heh. :) Maybe @kangtastic will want to merge the Vyatta integration changes into his fork.

@kangtastic
Copy link

kangtastic commented Dec 19, 2017

Hi @univerio. I remember thinking you did a much better job playing nice with EdgeOS's facilities for a system service than I did of playing nice with systemd - I just kinda faked it with an init.d script that is also a config file parser. I'll look into your work more in-depth over the holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants