Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richer alerts; improved docs; easier testing #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jinnko
Copy link

@jinnko jinnko commented Sep 2, 2023

You may not want to merge this, but thought I'd share just in case.

From the individual commit message:

  • Alerts now:
    • link to the alertmanager URL and a dashboard if env vars are
      configured.
    • all labels other than explicitly formatted labels are included in the
      alert output
    • when annotation.url is set the link will be included in the alert
    • fixed extra spaces that broke the alert link
    • emit the alert severity instead of "firing" when available
  • New logging module with configurable log level.
  • Cleaner contianer

jinnko added 5 commits September 2, 2023 14:43
We only need the src folder in the build container, not all the other
cruft.
New logging module with configurable log level.
Alerts now:

- link to the alertmanager URL and a dashboard if env vars are
  configured.
- all labels other than explicitly formatted labels are included in the
  alert output
- when annotation.url is set the link will be included in the alert
- fixed extra spaces that broke the alert link
- emit the alert severity instead of "firing" when available
Copy link
Contributor

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW these all seem like sensible improvements to me. They're orthogonal though, each commit could be it's own PR and be merged independently.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jelmer Vernooij <jelmer.vernooij@aiven.io>
@jinnko
Copy link
Author

jinnko commented Oct 10, 2023

@jelmer - yes - I intentionally make commits each with their own goal - so you're right they could be their own PRs. If you merge without squashing they will continue to be discrete changes in the history.

As they're all applied on my forked master branch - I guess the alternative would be to cherry pick each commit into it's own branch and raise multiple PRs - but the end result would be the same.

@jelmer
Copy link
Contributor

jelmer commented Oct 10, 2023

@jinnko makes sense - FWIM I'm not a committer to matrix-alertmanager, just an interested contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants