Log serialization warning when a panel errors. #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
force-pushed
the
serialization-warnings
branch
from
3ab6c19
to
b010305
Compare
matthiask
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Sorry for the bikeshedding. I thought the SERIALIZATION_WARNINGS switch would switch on warnings which would otherwise pass silently, but what it does is warn instead of raise exceptions.
I wonder if "SUPPRESS_SERIALIZATION_ERRORS": True wouldn't be a better name (after contextlib.suppress) but people should RTFM anyway so I think I'm fine with the name you choosed.
|
|
tim-schilling
force-pushed
the
serializable
branch
from
c70e89f
to
97fcda7
Compare
This will help third party panels identify issues with serializing the content of their panels in the future, without causing the entire toolbar to break.
tim-schilling
force-pushed
the
serialization-warnings
branch
from
b010305
to
b6128b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help third party panels identify issues with serializing the content of their panels in the future, without causing the entire toolbar to break.
Checklist:
docs/changes.rst.