Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the test matrix. #1816

Merged
merged 6 commits into from
Oct 14, 2023

Conversation

tim-schilling
Copy link
Contributor

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@tim-schilling
Copy link
Contributor Author

tim-schilling commented Jul 23, 2023

This is failing due to python/cpython#107088 which causes <listcomp> to no longer appear in the cProfile stats. On the plus side, we can likely remove this test for future versions of python if that's the case. Though ideally we'd have a better way to tell a user that this code is a problem.

docs/changes.rst Outdated Show resolved Hide resolved
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
@tim-schilling
Copy link
Contributor Author

This is blocked by psycopg/psycopg#626

We could bypass this by using psycopg

Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like psycopg released a compatible package so the CI can be rerun.

@tim-schilling tim-schilling merged commit 036e8db into jazzband:main Oct 14, 2023
26 checks passed
@tim-schilling tim-schilling deleted the python-3.12 branch October 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants