Hacky way of getting the toolbar to work under ASGI #1818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the serialization logic begins throwing exceptions we can consider subclassing the encoder class and using force_str on the object itself.
Add the Store API and initial documentation.
|
@matthiask what is all included when you say "almost everything just works"? |
|
@tim-schilling I'm sorry, that was premature. I was happy that it worked at all and didn't check thoroughly. Templates, caches, headers etc. work fine, and requests go through (responses are actually returned to the client) so that's much bette than the status quo already but not that much either. Still, I think making the toolbar middleware async-only may be the way to go. |
|
No worries. I'm just trying to understand what you tested to confirm that it works. |
tim-schilling
force-pushed
the
serializable
branch
from
c70e89f
to
97fcda7
Compare
|
Closing this for now since I didn't have any bandwidth to continue working on this during the last few months. This probably will not change soon so I'm setting my priorities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tim-schilling I got the idea to try what happens when converting all of the toolbar to run in async mode only and let Django handle the synchronous case. Surprisingly enough almost everything just works. I don't know if we should pursuse this path but if we can let Django to the sync/async coordination we would have much much less to do.