Async integration tests #2001
Async integration tests #2001
Conversation
There was a problem hiding this comment.
I read the Django docs regarding async_client and now it seems to me that the tests should do what I think they do.
I really wish the reviewing interface would show what actually changed compared to the sync integration tests. Maybe we could copy the file in a separate pull request and start changing it later the next time we do something similar so that the reviewing interface is more helpful.
|
|
||
| @override_settings(ROOT_URLCONF="tests.urls_use_package_urls") | ||
| async def test_include_package_urls(self): | ||
| """Test urlsconf that uses the debug_toolbar.urls in the include call""" |
There was a problem hiding this comment.
Maybe that comment was already there, but I don't understand it.
tests/test_integration_async.py
Outdated
| self.assertContains(response, "ASCII") # template | ||
| self.assertContains(response, "djDebug") # toolbar | ||
|
|
||
| response = self.client.get("/regular/LÀTÍN/") |
There was a problem hiding this comment.
Should this be async_client?
There was a problem hiding this comment.
Ah, I missed it, though it seems to fail at async_client ; )
There was a problem hiding this comment.
I am not sure why assert is failing cause manually it seems to work. for now I am changing LATIN to ASCII for this too.
…s over concurrent db queries
for more information, see https://pre-commit.ci
… with async client asserion
There was a problem hiding this comment.
I think this is a good change and we should merge it, or do you have any reservations @tim-schilling ?
|
@matthiask I didn't review it thoroughly, but it looks like test changes. I'm good with merging them if you're happy. I'll be less busy in ~2 weeks |
|
Let's do this then :) Thanks! |
Description
integrations tests to test the async toolbar.
Fixes # (issue)
Checklist:
docs/changes.rst.