Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from TinyMCE 5 to TinyMCE 6 #457

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Feb 18, 2024

No description provided.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e4d420) 90.20% compared to head (945d572) 87.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   90.20%   87.14%   -3.07%     
==========================================
  Files           6        6              
  Lines         286      249      -37     
  Branches       51       45       -6     
==========================================
- Hits          258      217      -41     
- Misses         12       15       +3     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudep
Copy link
Contributor Author

claudep commented Mar 1, 2024

We'll see if we get more testing inside master tree.

@claudep claudep merged commit f04e1c8 into jazzband:master Mar 1, 2024
10 of 11 checks passed
@claudep claudep deleted the tiny6 branch March 1, 2024 22:01
@marius-mather
Copy link
Contributor

@claudep I am trying out the version from master in my project and it seems to be working well for me, although my requirements are fairly simple - basically just doing some configuration of the editor toolbar, and using HtmlField to store it in my models.

An official release would be great - I was using https://github.com/django-ckeditor/django-ckeditor but that is now stuck on an insecure, unsupported version, and this would be a good replacement.

@claudep
Copy link
Contributor Author

claudep commented Mar 23, 2024

Thanks a lot for the feedback! I guess that #460 is still more or less a blocker, and should be solved (either by upstream or us removing the offending lines) before pushing a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants