-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sourceMappingURL lines from tinymce static files #461
Conversation
Thanks, it's probably the best move for now. Do you think we could add a regression test for that, so we don't forget to reapply this in future lib updates, if the upstream project doesn't fix this issue? |
I've added a test that just tries to run |
tests/test_static_files.py
Outdated
.map files can cause this to fail if the static | ||
files refer to them (GH issue #460) | ||
""" | ||
temp_dir = tempfile.mkdtemp() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the test! Now to be absolutely clean, I think we should delete the temp_dir at the end of the test, something like self.addCleanup(shutil.rmtree, local_path)
. Or even better use the with tempfile.TemporaryDirectory() as temp_dir
context manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point, I've done that now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 87.14% 87.14%
=======================================
Files 6 6
Lines 249 249
Branches 45 45
=======================================
Hits 217 217
Misses 15 15
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Thanks! |
Closes #460 . This is just a workaround, the "ideal" solution is that TinyMCE either ships the
.map
files in their releases or removes references to them. But probably the easiest fix for now.