Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds twitter card for collections #375

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Adds twitter card for collections #375

merged 2 commits into from
Dec 22, 2020

Conversation

cindywu
Copy link
Member

@cindywu cindywu commented Dec 21, 2020 •
edited
Loading

This PR adds meta_title and meta_twitter_description to generate twitter cards for collections.

Updates twitter cards for posts, so title defaults to Untitled and author to Anonymous when those fields are not present.

Twitter cards cannot be tested locally, so this will be tested live.

Addresses #353

Collection twitter card design
image

Post twitter card design
image

@linear
Copy link

linear bot commented Dec 21, 2020

JEL-228 twitter card for collections

  • make twitter card for collections pages tags
  • 2+ posts and 2+ references
  • 1 post and 2+ references
  • 2+ posts and 1 reference
  • 2+ posts and 0 references
  • 1 post and 0 references
  • 0 posts and 0 references

Design System 2020-12-20 13-56-55.png

cindy on Twitter: "https:::t.co:1CxNWCMiER" : Twitter 2020-11-08 17-21-43.png

@cindywu cindywu requested a review from dennyluan December 21, 2020 07:32
@dennyluan dennyluan temporarily deployed to jellyposter-cindy-jel-2-dtictb December 21, 2020 07:34 Inactive
dennyluan
dennyluan requested changes Dec 22, 2020
View reviewed changes
app/helpers/tags_helper.rb Outdated Show resolved Hide resolved
@cindywu cindywu requested a review from dennyluan December 22, 2020 07:08
@dennyluan dennyluan temporarily deployed to jellyposter-cindy-jel-2-ycteed December 22, 2020 07:09 Inactive
@cindywu cindywu merged commit cb5a692 into master Dec 22, 2020
@cindywu cindywu deleted the cindy/jel-228-twitter-card-for-collections branch December 22, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennyluan dennyluan dennyluan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cindywu @dennyluan