Auto indent feature add #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jendrikseipp
requested changes
Apr 25, 2021
| @@ -53,6 +53,7 @@ class Config(dict): | |||
| "leftDividerPosition": 260, | |||
| "rightDividerPosition": None, | |||
| "cloudMaxTags": 1000, | |||
| "autoindent": 1, | |||
There was a problem hiding this comment.
Can you use "autoIndent" here and auto_indent in the rest of the code, please?
| if self.journal.config.read("autoindent") == 1: | ||
| self.day_text_field.day_text_view.set_auto_indent(True) | ||
| else: | ||
| self.day_text_field.day_text_view.set_auto_indent(False) |
There was a problem hiding this comment.
Let's shorten this a bit:
def set_auto_indent(self):
auto_indent = self.journal.config.read("autoindent") == 1
self.day_text_field.day_text_view.set_auto_indent(auto_indent)
| @@ -1,6 +1,7 @@ | |||
| # Unreleased | |||
| * Add a "Give Feedback" button (#551, Rahul Jha). | |||
| * Test code on macOS (#552, Rahul Jha). | |||
| * added feature to auto-indent text in editor (#561, Allen Benter) | |||
There was a problem hiding this comment.
Add option to auto-indent text (#561, Allen Benter).
|
This feature has been requested also in issue #561. It would be cool if we could merge this PR. Do you have the time to make the changes I suggested? |
|
Hi Jendrik,
I'm no longer using RedNotebook so won't be able to complete the PR.
Thank you for all your time and effort in developing the app.
Cheers,
…--
Dr Allen Benter
Technical Specialist Digital Agriculture
Climate | DPI Agriculture
Department of Regional NSW
M 0418 716 688
E ***@***.******@***.***>
W dpi.nsw.gov.au/dpi/climate<https://www.dpi.nsw.gov.au/dpi/climate>
Orange Agriculture Institute
1447 Forest Road, Orange 2800
[cid:bda6e39e-187b-467b-b397-4fb042af7680]<https://www.regional.nsw.gov.au/>
Department of Primary Industries
Department of Regional NSW
________________________________
From: Jendrik Seipp ***@***.***>
Sent: Thursday, 29 December 2022 9:13 AM
To: jendrikseipp/rednotebook ***@***.***>
Cc: Allen Benter ***@***.***>; Author ***@***.***>
Subject: Re: [jendrikseipp/rednotebook] Auto indent feature add (#562)
This feature has been requested also in issue #561<#561>. It would be cool if we could merge this PR. Do you have the time to make the changes I suggested?
—
Reply to this email directly, view it on GitHub<#562 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGNKXL3E2IW2T6YIPDVM2OLWPS3SLANCNFSM4Y2XUNUA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes in this pull request
Added feature to enable auto indent in editor.
Pull request checklist
CHANGELOG.mdincluding my name and issue and/or pull request number.TODO.md.