Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a dockerfile #614

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

echaz
Copy link

@echaz echaz commented Feb 27, 2022

Summary of the changes in this pull request

non-linux releases of rednotebook are a bit of a pain. So for all those of you out there who know how to both xwindows and docker, why not just run it on a linux container?

I dont know how useful this is for others, it is certainly useful for me for when I switch mac laptops and dont want to have to do a giant dance involving brew, gtk installations and lots of time.

As a side note, I believe the icon theme listed on line 20 is missing from your ubuntu apt definition. I got a bunch of warnings before I installed that.

Pull request checklist

  • I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
  • If applicable: I have removed the corresponding entry in TODO.md.

Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I tried to make the steps a bit clearer. Can you double-check, please? Also, could you add more detailed instructions on the parts about Cygwin, xwindows and startx? I know nothing about these.

@echaz
Copy link
Author

echaz commented Mar 5, 2022

yup, I'll try to get to it this weekend. I should be able to test this out in both environments.

Also, how do we add "adwaita-icon-theme-full" to the ubuntu configuration denoted in "ppa:rednotebook/stable", so I don't need to enumerate it out in the dockerfile.

@jendrikseipp
Copy link
Owner

@kathenas What do you think about adding adwaita-icon-theme or adwaita-icon-theme-full to debian/control? I'm unsure whether one of these core GTK package should be a hard dependency.

@kathenas
Copy link
Contributor

kathenas commented Mar 8, 2022

@kathenas What do you think about adding adwaita-icon-theme or adwaita-icon-theme-full to debian/control? I'm unsure whether one of these core GTK package should be a hard dependency.

On Debian/Ubuntu when libgtk-3-0 is pulled in, the packages adwaita-icon-theme and hicolor-icon-theme are also with other packages additionally depending on the Desktop Environment. Adding a hard dependency is not warranted.

@jendrikseipp
Copy link
Owner

Thanks for clarifying!

@jendrikseipp
Copy link
Owner

@echaz Do you still want to pursue this (see my earlier message #614 (review) for the next steps)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants