Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting bump jjwt from 0.11.5 to 0.12.2 #382

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Reverting bump jjwt from 0.11.5 to 0.12.2 #382

merged 1 commit into from
Oct 10, 2023

Conversation

alecharp
Copy link
Collaborator

@alecharp alecharp commented Oct 9, 2023 •
edited
Loading

Description

Introduced in #374.

The API changes made in jwtk/jjwt#794 were are not ported to GitHub API project. Until then, the new version cannot be used.

Testing done

I ran the application locally with the new version of the dependency and saw that tokens were not produced correctly.
Found the pull request changing the API of the interface.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. If an issue exists, it is well described and linked in the description
    Options
  2. The description of this pull request is detailed and explain why this pull request is needed
    Options
  3. The changeset is on a specific branch. Using feature/ for new feature, or improvements ; Using fix/ for bug fixes ; Using docs/ for any documentation changes.
    Options
  4. If required, the documentation has been updated
    Options
  5. There is automated tests to cover the code change / addition or an explanation why there is no tests in the description.
    Options
Loading

@alecharp
Reverting 9590799
9c61acb 
The API changes made in jwtk/jjwt#794 were are not ported to GitHub API project.
Until then, the new version cannot be used.
@alecharp alecharp added the bug Something isn't working label Oct 9, 2023
@alecharp alecharp changed the title Reverting 9590799bf63eb20bb1b6707746898972ab04eb5e Reverting bump jjwt from 0.11.5 to 0.12.2 Oct 10, 2023
@alecharp alecharp merged commit 241a23f into jenkins-infra:main Oct 10, 2023
20 checks passed
@alecharp alecharp deleted the fix/revert-bump-jjwt-0.11.5-to-0.12.2 branch October 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alecharp