Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser for CCES (CrossCore Embedded Studio) #937

Merged
merged 8 commits into from
Aug 1, 2023

Conversation

arthur-devialet
Copy link
Contributor

@arthur-devialet arthur-devialet commented Jul 31, 2023

Add support for parsing compiler logs generated by CrossCore Embedded Studio.

Notes

  • Implementation inspired from Gcc4CompilerParser.java and EmbeddedEngineerParser.java
  • Compiler errors are not parsed, only warnings. Could be improved in a second stage

Testing done

  • Added relatively extensive tests in CrossCoreEmbeddedStudioParserTest.java

See also

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Extra:

  • Update SUPPORTED-FORMATS.md.
    Not clear to me how to "run main method of ParserRegistry". Where is the binary? (Note that my java level is extremely low)

@arthur-devialet arthur-devialet changed the title Add parser for CCES (CrossCore Embedded Studio from Analog Devices) Add parser for CCES (CrossCore Embedded Studio) Jul 31, 2023
@uhafner uhafner added the feature New features label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #937 (7df9a9a) into master (457db4c) will increase coverage by 0.00%.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##             master     #937   +/-   ##
=========================================
  Coverage     92.91%   92.91%           
- Complexity     2333     2338    +5     
=========================================
  Files           343      345    +2     
  Lines          6479     6495   +16     
  Branches        671      672    +1     
=========================================
+ Hits           6020     6035   +15     
  Misses          262      262           
- Partials        197      198    +1     
Files Changed Coverage Δ
...du/hm/hafner/analysis/registry/ParserRegistry.java 100.00% <ø> (ø)
...analysis/parser/CrossCoreEmbeddedStudioParser.java 91.66% <91.66%> (ø)
...is/registry/CrossCoreEmbeddedStudioDescriptor.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your PR.

Can you please regenerate the SUPPORTED_FORMATS file by running mvn verify?

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@uhafner uhafner merged commit feef545 into jenkinsci:master Aug 1, 2023
25 checks passed
@arthur-devialet arthur-devialet deleted the arthur/add-CCES-parser branch August 2, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants