Removed 4 unnecessary stubbings in RoundhouseActionTest.java

[ARUS2023]

Testing done

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

In our analysis of the project, we observed that

1. 1 unnecessary stubbing which stubbed getResult method in RoundhouseActionTest.setUp is created but is never executed by the test RoundhouseActionTest.testGetProjectActionsFromLastProjectBuild;

2. 4 unnecessary stubbings RoundhouseActionTest.setUp are created but are never executed by 2 tests RoundhouseActionTest.testAccessors, RoundhouseActionTest.testGetProjectActions;

3. 3 unnecessary stubbings which stubbed getParent method, getLastCompletedBuild method, getActions method in RoundhouseActionTest.setUp are created but never executed by the tests RoundhouseActionTest.testGetStyleFromRunResult.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

[MarkEWaite]

Please use JUnit 4 rather than JUnit 3 for the tests. JUnit 4 is more familiar to Jenkins developers and is widely used in Jenkins plugins. See the stackoverflow article for more details on why JUnit 4 annotations are better than JUnit 3 inheritance.

Note that this suggestion won't compile if you apply it directly.

Suggested change

	public class SecondRoundhouseActionTest extends TestCase {
	public class SecondRoundhouseActionTest {

[MarkEWaite]

Please use JUnit 4 rather than JUnit 3 for the tests. JUnit 4 is more familiar to Jenkins developers and is widely used in Jenkins plugins. See the stackoverflow article for more details on why JUnit 4 annotations are better than JUnit 3 inheritance.

Note that this suggestion won't compile if applied directly. Switching to JUnit 4 requires more than this single change.

Suggested change

	public class ThirdRoundhouseActionTest extends TestCase {
	public class ThirdRoundhouseActionTest {