Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: jdk21-prerequisites #230

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

gounthar
Copy link
Contributor

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21.

Supersedes #228 .
Supersedes #229 .

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/scRqm3Y6Q?organizationId=SmVua2lucyBDSQ%3D%3D

Co-authored-by: Moderne <team@moderne.io>
@gounthar gounthar requested a review from a team as a code owner November 15, 2023 10:10
@batmat batmat enabled auto-merge November 16, 2023 14:15
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and I'll check the master branch status afterwards. Because given how the permission model works, this PR's real content wasn't really tested (contrary to what the green checks suggest).

I just did a local quick build with JDK17 and it passed, so I think this should be fine. This plugin doesn't have a lot of code.

@batmat batmat merged commit 5f7652a into jenkinsci:master Nov 16, 2023
15 checks passed
@gounthar gounthar deleted the refactor/jdk-21-prerequisites branch November 16, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants